Repository navigation
Make mobile sidebar menu button visible on dark navbar - #893
Merged
Merged
Conversation
The sidebar toggle icon inherited the dark body text color, making it nearly invisible against the dark navbar background on narrow screens. Use the navbar font color, and the navbar link hover color on hover.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On narrow screens (mobile) the sidebar menu (hamburger) button was barely visible: its icon uses
currentColorand inherited the dark body text color (#2c3e50) on top of the dark navbar background (#082336).This sets the button to
$navbarFontColor(white), with$navbarLinksHoverColoron hover — the same palette the navbar links already use.Before / After